mark const fn constructors as rustc_const_stable_indirect #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
approved these changes
Nov 13, 2024
|
I assume you need a new hashbrown release with this? |
|
Yeah to use this in std this will need a release.
|
|
I think you won't be able to bootstrap that until the new attribute reaches beta for stage0. |
|
Ah, true, good point. There's a beta branching in about a week so that's not too long of a wait. :) But I should probably double-check that this will actually work... |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2024
…r=compiler-errors check_consts: fix error requesting feature gate when that gate is not actually needed When working on rust-lang/hashbrown#586 I noticed that the compiler asks for the `rustc_private` feature to be enabled if one forgets to set `rustc_const_stable_indirect` on a function -- but enabling `rustc_private` would not actually help. This fixes the diagnostics. r? `@compiler-errors`
|
I checked that if I do make these |
|
The bootstrap bump should happen any day now. @Amanieu would be nice to get a release. :) |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a promise that they can be implemented entirely using stable const features (and the compiler checks this when
-Zforce-unstable-if-unmarkedis set).Part of rust-lang/rust#102575.