Parse grammars with proc_macro tokens and remove "negative lookahead".
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2019
CAD97
approved these changes
May 14, 2019
Cargo.toml
Outdated
| @@ -31,7 +31,7 @@ doctest = false | |||
| test = false | |||
|
|
|||
| [patch.'crates-io'] | |||
| grammer = { git = "https://github.com/lykenware/grammer", rev = "e108acbe83271761538bf5b2ff2daeaaafa5919c" } | |||
| grammer = { git = "https://github.com/lykenware/grammer", rev = "d4f2dcd2e35c31cee0acd08ad5bcc898704004a9" } | |||
There was a problem hiding this comment.
To avoid downstream users having to specify the grammer revision, this should be upgraded to a "proper" git dependency rather than going through [patch.crates-io] which only applies from the root manifest.
There was a problem hiding this comment.
I want to get rid of this soon by releasing the first version of grammer, once it's useful by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110 and closes #14 (without providing a replacement).