Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GIT_FILEMODE_BLOB_GROUP_WRITABLE #887

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Add support for GIT_FILEMODE_BLOB_GROUP_WRITABLE #887

merged 1 commit into from
Apr 1, 2023

Conversation

malor
Copy link
Contributor

@malor malor commented Oct 2, 2022

This type no longer exists in modern git, but there are existing git repositories out there with tree entries of this type (e.g. Linux kernel). Currently, traversing commits of a repository like that leads to a panic in DiffFile::mode().

This type no longer exists in modern git, but there are existing git
repositories out there with tree entries of this type (e.g. Linux
kernel). Currently, traversing commits of a repository like that leads
to a panic in DiffFile::mode().
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is a API-breaking change since it adds to an enum without non_exhaustive. However, since we are bumping the version it should be ok to land now.

@ehuss ehuss merged commit 76897b8 into rust-lang:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants