Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tree::get_name_bytes to handle non-UTF-8 entry names #841

Merged
merged 2 commits into from
May 10, 2022
Merged

Add Tree::get_name_bytes to handle non-UTF-8 entry names #841

merged 2 commits into from
May 10, 2022

Conversation

joshtriplett
Copy link
Member

No description provided.

@alexcrichton
Copy link
Member

Could get_name be reimplemented in terms of this method?

@joshtriplett
Copy link
Member Author

@alexcrichton Good idea, will do.

alexcrichton
alexcrichton approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right but otherwise seems good to me!

@joshtriplett joshtriplett merged commit adef77b into rust-lang:master May 10, 2022
@joshtriplett joshtriplett deleted the tree-get-name-bytes branch May 10, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshtriplett @alexcrichton