Add BlockAwait trait
#2803
Closed
Add BlockAwait trait
#2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Users are free to define such helpers themselves, but I would prefer that this not be provided as part of the futures crate. Thanks anyway for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds in a trait called
BlockAwait, which functions likefutures::executor::block_on, but allows for a chaining style similar to.awaitsyntax.I wasn't positive if this would be wanted, but considering how simple it was I decided I'd just go ahead and make it.
I also wasn't completely sure on how I should limit the trait to only be implemented on
Futuretypes (and possibly how to prevent it's implementation from being overridden), but I'm open to feedback in the area if my implementation isn't the best.