Cleanup CI config #1980
Cleanup CI config #1980
Conversation
| # * `--exclude futures-test` - futures-test cannot be compiled with no-default features | ||
| # * `--features unstable` - some features cannot be compiled without this feature | ||
| # * `--ignore-unknown-features` - some crates doesn't have 'unstable' feature | ||
| - cargo hack check |
There was a problem hiding this comment.
The actual command description is in this comment.
| - cargo build --all | ||
| # Check compat & thread-pool & async-await features |
There was a problem hiding this comment.
It should be sufficient to check these features on 1.36.0 build and features check (also async-await feature is activated by default).
| script: | ||
| - if ! rustup component add clippy; then | ||
| install: | ||
| - if ! rustup component add clippy 2>/dev/null; then |
There was a problem hiding this comment.
Alternatively the cargo clippy build could be moved to use stable now, there's no reason this needs nightly afaik?
There was a problem hiding this comment.
Some unstable features require nightly rustc:
https://github.com/rust-lang-nursery/futures-rs/blob/d309ea397581efefeacaa5a928d33b0ec6e87834/futures-core/src/lib.rs#L3
https://github.com/rust-lang-nursery/futures-rs/blob/d309ea397581efefeacaa5a928d33b0ec6e87834/futures-io/src/lib.rs#L11
1.36.0 buildandfeatures checkby using cargo-hackcargo-hack provides workarounds for some cargo limitations/bug(
cargo test --allignores different feature sets for different members in a workspace cargo#3620, Testing workspace package with features expects the root package to have those features cargo#4106, Feature selection in workspace depends on the set of packages compiled cargo#4463, Add support for --features and --no-default-features flags in workspace builds cargo#4753, build-dependencies and dependencies should not have features unified cargo#4866, Feature selection in workspace depends on the set of packages compiled cargo#4463, New behavior of--feature+--packagecombination cargo#5364, Testing whole workspace with features enabled in some crate(s) cargo#6195, Allow crates to be published with cyclic dev-dependencies cargo#4242),and some useful features for testing. (description of each feature is in the comments.)
related: chore: check each feature works properly tokio-rs/tokio#1695 (the context in which I wrote this tool)