Use AtomicWaker in mpsc #1317
Merged
Use AtomicWaker in mpsc #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
reviewed
Nov 9, 2018
... so `AtomicWaker` could be used inside `futures-channel`. `AtomicWaker` is still accessible to users only from `futures-util`.
stepancheg
force-pushed
the
mpsc-atomic-waker
branch
5 times, most recently
from
22658fd
to
3fb3baf
Compare
AFAIU AtomicWaker is a perfect candidate to use in mpsc receiver. This patch is good because: * it enabled `AtomicWaker` dogfooding * it is a good example of `AtomicWaker` proper (I hope) usage * it kills overcomplicated logic of `ReceiverTask`
stepancheg
force-pushed
the
mpsc-atomic-waker
branch
from
3fb3baf
to
f346525
Compare
|
OK, finally after 10 iterations I managed to move |
|
First commit moves |
|
Heh, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIU AtomicWaker is a perfect candidate to use in mpsc receiver.
This patch is good because:
AtomicWakerdogfoodingAtomicWakerproper (I hope) usageReceiverTask