empty commit for CI check

[oyvindln]

No description provided.

[oyvindln]

Well the cloudflare_zlib test failed but not in the expected way...

[Byron]

Thanks a lot!

That's true! The roundtrip test fails which is very strange. Compilation is working though, so that's probably a good sign.

What's not great is that CI seems to be broken by Rust v1.84 as they don't ship 'wasm32-wasi' anymore, but now provide 'wasm32-wasip1'? Would you be able to swap this out (it will work, I did the same already elsewhere)?

Further, could you try to pin the libz-sys crate to the previous patch level? Ideally CI would pass then and we would know it's truly something that happened there. From there we should be able reel in the right people to sort out what truly happened with libz-sys.

[Byron]

Could you try to push a commit with #441 reverted to see if that's related to the roundtrip test? It probably is not going to affect it.

It's notable that the roundtrip test isn't failing on MacOS when running it locally.

❯ cargo test --features cloudflare_zlib --no-default-features
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.01s
     Running unittests src/lib.rs (target/debug/deps/flate2-c50f5035a4da712f)

running 49 tests
test gz::tests::fields ... ok
test gz::read::tests::blocked_partial_header_read ... ok
test deflate::bufread::test::decode_extra_data ... ok
test deflate::tests::zero_length_read_with_data ... ok
test deflate::tests::drop_writes ... ok
test gz::bufread::test::decode_extra_data ... ok
test deflate::write::tests::decode_extra_data ... ok
test gz::tests::keep_reading_after_end ... ok
test gz::tests::roundtrip_header ... ok
test gz::tests::roundtrip ... ok
test deflate::tests::qc_reader ... ok
test gz::tests::roundtrip_zero ... ok
test gz::tests::qc_reader ... ok
test gz::tests::flush_after_write ... ok
test gz::write::tests::decode_writer_exact_header ... ok
test gz::write::tests::decode_extra_data ... ok
test gz::write::tests::decode_writer_one_chunk ... ok
test mem::tests::issue51 ... ok
test gz::write::tests::decode_writer_partial_header_comment ... ok
test gz::write::tests::decode_multi_writer ... ok
test mem::tests::set_dictionary_raw ... ok
test gz::write::tests::decode_writer_partial_header_filename ... ok
test mem::tests::set_dictionary_with_zlib_header ... ok
test mem::tests::test_error_message ... ok
test gz::write::tests::decode_writer_partial_header ... ok
test mem::tests::test_gzip_flate ... ok
test gz::write::tests::decode_writer_partial_crc ... ok
test zlib::tests::bad_input ... ok
test zlib::bufread::test::decode_extra_data ... ok
test zlib::tests::drop_writes ... ok
test mem::tests::reset ... ok
test zlib::tests::qc_reader ... ok
test deflate::tests::roundtrip ... ok
test zlib::write::tests::decode_extra_data ... ok
test deflate::tests::total_in ... ok
test zlib::tests::total_in ... ok
test gz::tests::roundtrip_big ... ok
test zlib::tests::roundtrip ... ok
test deflate::tests::qc_writer ... ok
test zlib::tests::qc_writer ... ok
test deflate::tests::roundtrip2 ... ok
test gz::tests::roundtrip_big2 ... ok
test zlib::tests::roundtrip2 ... ok
test zlib::tests::roundtrip3 ... ok
test deflate::tests::roundtrip3 ... ok
test deflate::tests::reset_decoder ... ok
test zlib::tests::reset_decoder ... ok
test deflate::tests::reset_reader ... ok
test deflate::tests::reset_writer ... ok

test result: ok. 49 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.42s

     Running tests/early-flush.rs (target/debug/deps/early_flush-42df9a23f89f0e01)

running 1 test
test smoke ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/empty-read.rs (target/debug/deps/empty_read-6f1d72798afcdcf5)

running 6 tests
test deflate_encoder_empty_read ... ok
test zlib_encoder_empty_read ... ok
test gzip_encoder_empty_read ... ok
test deflate_decoder_empty_read ... ok
test gzip_decoder_empty_read ... ok
test zlib_decoder_empty_read ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/gunzip.rs (target/debug/deps/gunzip-11e8d0c223e64ecd)

running 5 tests
test empty_error_once ... ok
test test_extract_success_partial_multi ... ok
test test_extract_failure ... ok
test test_extract_success_multi ... ok
test test_extract_success ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/zero-write.rs (target/debug/deps/zero_write-d91185a89e5c8ad7)

running 1 test
test zero_write_is_error ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests flate2

running 22 tests
test src/gz/bufread.rs - gz::bufread::GzEncoder (line 30) ... ok
test src/gz/read.rs - gz::read::GzEncoder (line 18) ... ok
test src/deflate/write.rs - deflate::write::DeflateEncoder (line 16) ... ok
test src/gz/write.rs - gz::write::GzEncoder (line 19) ... ok
test src/deflate/bufread.rs - deflate::bufread::DeflateDecoder (line 140) ... ok
test src/deflate/write.rs - deflate::write::DeflateDecoder (line 183) ... ok
test src/deflate/bufread.rs - deflate::bufread::DeflateEncoder (line 18) ... ok
test src/deflate/read.rs - deflate::read::DeflateDecoder (line 136) ... ok
test src/deflate/read.rs - deflate::read::DeflateEncoder (line 16) ... ok
test src/gz/write.rs - gz::write::GzDecoder (line 187) ... ok
test src/gz/bufread.rs - gz::bufread::GzDecoder (line 186) ... ok
test src/gz/read.rs - gz::read::GzDecoder (line 111) ... ok
test src/gz/read.rs - gz::read::MultiGzDecoder (line 218) ... ok
test src/gz/bufread.rs - gz::bufread::MultiGzDecoder (line 371) ... ok
test src/gz/mod.rs - gz::GzBuilder (line 300) ... ok
test src/lib.rs - (line 46) ... ok
test src/zlib/bufread.rs - zlib::bufread::ZlibDecoder (line 145) ... ok
test src/zlib/bufread.rs - zlib::bufread::ZlibEncoder (line 18) ... ok
test src/zlib/read.rs - zlib::read::ZlibDecoder (line 142) ... ok
test src/zlib/read.rs - zlib::read::ZlibEncoder (line 17) ... ok
test src/zlib/write.rs - zlib::write::ZlibDecoder (line 191) ... ok
test src/zlib/write.rs - zlib::write::ZlibEncoder (line 16) ... ok

test result: ok. 22 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.48s

[oyvindln]

Tried reverting - it still builds fine but it's failing on nightly instead of macos now, and on one of the stable tests...

Looking at the roundtrip tests, one thing I noticed that is not entirely ideal, though I don't know if it has any bearing on the results is that it is using data that is generated using a random function so it won't be consistent between runs

[Byron]

Thanks for trying! I will try to tackle this today and fix it one way or another - CI has to be back.