2024: rustfmt sorting #332
Merged
+50
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Nov 4, 2024
src/rust-2024/rustfmt-sorting.md
Outdated
|
|
||
| ## Migration | ||
|
|
||
| The change can be applied automatically by running `cargo fmt` or `rustfmt` with the 2024 Edition. |
There was a problem hiding this comment.
If permissible, I'd like to avoid having to repeat the "here's how to run rustfmt" text in however many style/rustfmt pages we end up having.
Would it suffice to have this one-liner under our migration sections, and then just link out to the detailed instructions for how to do so, which will be added as part of #331?
There was a problem hiding this comment.
Linking out to #331 sounds good to me!
|
If you think it is best to have separate pages, that sounds good to me. Just FYI, eventually we'll reorder and group the pages in SUMMARY.md. Right now they are kinda in random order. |
This is to differentiate with rustfmt-raw-identifier-sorting.
We generally use sentence case for chapter titles.
ehuss
force-pushed
the
rustfmt-sorting
branch
from
54c94fd
to
7826b2c
Compare
ehuss
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tracking issues:
rust-lang/rust#123800
rust-lang/rust#123802
rendered
A topic we discussed back in #321 was how to bucket the various style/rustfmt related items, many of which are relatively small.
I know we have 3 separate tracking issues covering more detailed levels of the sorting change, but when I put myself in the position of a user consuming this edition guide I'm thinking it would be more intuitive to have a single page/section for the sorting changes