Change layout to fix missing scrollbar highlighting (chromium text search) #635
Conversation
|
Will this bring back the issue mentioned in #510 (comment) ? |
|
@jyn514 I can't really reproduce the anchor issue? |
cynecx
force-pushed
the
fix-chrome-search-highlight
branch
from
36fa43b to
962e3e1
Compare
|
It was there a couple months ago, if it's not present in your PR that's a good sign. |
|
I'm not sure to understand the connection between the remove code and the theme picker menu... |
|
@GuillaumeGomez Without it, it seems that the theme-picker is misaligned, why? I don’t really know, hence I have mentioned that this is more like a hack and not a proper fix. I can’t really take screenshots now because I am not anywhere near a computer, but you can try out these changes directly in your browser and you will probably see what the issue is. |
|
It's currently working for on my computer without those changes. So I'd definitely like to have screenshots. :) |
|
Patch without fix for theme-picker:
With theme-picker:
(On Chromium 80.0.3987.132) |
|
Ok, I confirm that your change doesn't break things on firefox and chrome. Thanks for the fix! |
|
Well, I think I broke it. I assume that this went already to production because it seems that I can reproduce the mentioned anchor issue. 🤔 Weird thing is, it worked quite fine when I tested it (Developer Tools). My guess would be that this has to do with modifying the css on-the-fly vs statically. |
|
Did you try to empty the cache? Check if the CSS is the one from this PR to be sure it's yours too. |
|
@GuillaumeGomez Yes, in fact I have disabled it xD. And yes again, the css contains this PR. |
|
The new style is definitely there (tested on https://docs.rs/regex/1.3.5/regex/) and is working for me. You're sure your chromium is "fin"? :p |
|
Firefox has the same behavior as Chromium. :/ |
|
Oh, that's what you meant! Yes, you definitely broke it. I completely forgot about the anchors... |
|
How should we proceed? I mean the trade off here doesn't seem that bad compared to losing the search highlighting functionality. Meanwhile: I am currently trying to find a workaround the fixed position of the sticky header. |
|
No, the new behavior is worse. We need to find a way to fix the theme picker without breaking the anchors. |
|
Well, I guess it's a revert then for now. PR is coming right up. |
Fixes #623.
This is more of a hack but I am not sure how a proper fix would look like.