Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RegistryApi in releases #2649

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Use RegistryApi in releases #2649

merged 3 commits into from
Oct 25, 2024

Conversation

SuficioAC
Copy link
Contributor

Follows #2642

After further testing I found further inconsistencies in URL handling so I made the jump and added this functionality to RegistryApi as @syphar suggested.

@SuficioAC SuficioAC requested a review from a team as a code owner October 21, 2024 22:20
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 21, 2024
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement!

With the comments fixed I would already do some testing and this could also be merged.

src/registry_api.rs Outdated Show resolved Hide resolved
src/web/releases.rs Outdated Show resolved Hide resolved
src/registry_api.rs Outdated Show resolved Hide resolved
@SuficioAC SuficioAC requested a review from syphar October 24, 2024 04:48
@syphar
Copy link
Member

syphar commented Oct 25, 2024

@SuficioAC can you rebase on master to resolve the conflicts? Then I'll merge

@SuficioAC
Copy link
Contributor Author

@syphar Rebased

@syphar syphar merged commit 8a866f3 into rust-lang:master Oct 25, 2024
7 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 25, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants