prevent race conditions when initializing crate record in DB #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
initialize-crate-race
branch
from
55cf2b1
to
c804649
Compare
syphar
force-pushed
the
initialize-crate-race
branch
from
c804649
to
1663ba6
Compare
GuillaumeGomez
approved these changes
Apr 17, 2024
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this I'm trying to prevent this sentry error while building:
I'm not sure yet where this can happen, I saw it once specifically with the crate
tencent(which is empty, but this shouldn't matter). Crate name normalization shouldn't change anything for this crate. Also the crate was queued only once in the queue, andSELECT FOR UPDATEshould prevent that the second builder would pick up the same release.In any case, this is the new impl for the method, taken from #2467, which would solve this specific error in all cases.