-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to increase a README character limit? #1866
Comments
I think we should consider just removing the limit; I don't know why it was added in the first place, but we don't limit the size of the pages rustdoc generates, so I don't know why we'd limit readmes either. |
There is a limit on rustdoc pages too, it's just (at least by default) a lot more lenient Lines 133 to 134 in b5451e0
I think the problem is the readme is stored in the database instead of being sourced from S3. I remember some discussion on storing the source archive even when the build fails but can't find the issue (related to #1011 though), once we have that then I think we can change to rendering from the source file instead of the database column which will implicitly remove the length restriction. (We could change to going to S3 when the source archive is available now, though that wouldn't help in this case because the build also failed). |
We upload the source archive even when the build fails, that shouldn't impact anything. I agree that's a good solution and would let us use the same limit for the readme as everything else (and as a bonus make the database a lot smaller). |
Ah yeah, that explains why I couldn't find the issue, it was already closed #607. We'll still need to read the database as a backup for crates that built before that was fixed until the mass rebuild. |
Crate name
tabled
Build failure link
https://docs.rs/crate/tabled/0.9.0
Requested RAM limit
No response
Requested timeout
No response
Requested number of targets
No response
Why your crate needs the resource increases
Hi there,
Yes....
I guess someone need to redo the README but is it possible to increase the limit?
Take care.
The text was updated successfully, but these errors were encountered: