Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crates to the database before building them #1011

Closed
jyn514 opened this issue Aug 27, 2020 · 1 comment · Fixed by #2533
Closed

Add crates to the database before building them #1011

jyn514 opened this issue Aug 27, 2020 · 1 comment · Fixed by #2533
Labels
A-builds Area: Building the documentation for a crate

Comments

@jyn514
Copy link
Member

jyn514 commented Aug 27, 2020

Right now, all targets are built before the crate is added to the database. We should change this:

  • We could avoid having documentation on S3 that isn't deleted if the queue reader panics and doesn't add the crate to the database (Upload sources even for binaries and failed builds #928 (comment)) - if a panic or crash happens, we can delete the documentation the next time the server starts up.

  • We could display documentation for the default target before all crates have finished being built. After that, we would upload each target as it completes.

  • We could show which crate is currently being built. Currently, the queue looks like this:
    image

This shows the crates that are scheduled, but doesn't say which is currently being built. You can usually infer that it's the first in the queue, but this isn't always the case - sometimes a crate will be de-prioritized while building, so it will show up at the bottom of the queue even though it's currently being built.

It would be great to show
a) which crate is being built
b) a link on /:crate/:version to the build queue

@jyn514 jyn514 added the A-builds Area: Building the documentation for a crate label Aug 27, 2020
@pietroalbini
Copy link
Member

This would also allow to create a "crate is queued to be built" page in https://docs.rs/:crate, while we wait for the first version of a crate to be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants