rss: Remove explicit/duplicate XML escaping

[Turbo87]

XML tags inside CDATA sections don't need to be escaped, so this explicit escaping step led to an unnecessary duplicate escaping being applied.

Related:

• Escaping of XML entities rust-syndication/rss#167 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (3640ab0) to head (6154581).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9973      +/-   ##
==========================================
- Coverage   89.22%   89.22%   -0.01%     
==========================================
  Files         293      293              
  Lines       30394    30394              
==========================================
- Hits        27120    27118       -2     
- Misses       3274     3276       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eth3lbert]

According to https://en.wikipedia.org/wiki/CDATA#Nesting, if I understand correctly, we need to encode ]]> if description contains it.

[Turbo87]

I added another commit that explicitly checks for ]]> escaping and it looks like you discovered a bug in the rss/quick-xml crate(s). It does not appear to get escaped properly. I'll report it over there and see if I can fix it.

[Turbo87]

Reported at:

• ]]> in CDATA is not escaped rust-syndication/rss#173
• ]]> in CDATA is not escaped tafia/quick-xml#831

Proposed fixes:

• Fix ]]> escaping in CDATA sections rust-syndication/rss#174
• Implement BytesCData::escaped() fn tafia/quick-xml#832

[Turbo87]

I'll merge this PR for now until the issue is fixed upstream :)