Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍱 Crop favicon #3411

Merged
merged 1 commit into from
Mar 14, 2021
Merged

🍱 Crop favicon #3411

merged 1 commit into from
Mar 14, 2021

Conversation

gleich
Copy link
Contributor

@gleich gleich commented Mar 14, 2021

Hello! At first glance I found crates.io's favicon to be a bit small compared to other site's favicons. Looked into it and found that the logo hasn't been cropped. All I did was crop the favicon in this PR. As you can see from the image below (new favicon on the right) it looks much better:

Screen Shot 2021-03-13 at 11 53 09 PM

Thank you, maintainers! :)

Signed-off-by: Matthew Gleich <[email protected]>
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Turbo87
Copy link
Member

Turbo87 commented Mar 14, 2021

LGTM, thanks! 👍

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2021

📌 Commit 1ef88c8 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Mar 14, 2021

⌛ Testing commit 1ef88c8 with merge daa2f4a...

@bors
Copy link
Contributor

bors commented Mar 14, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing daa2f4a to master...

@bors bors merged commit daa2f4a into rust-lang:master Mar 14, 2021
bors added a commit to rust-lang/cargo that referenced this pull request Mar 14, 2021
🍱 Crop favicon

Hello! At first glance I found doc.rust-lang.org/cargo's favicon to be a bit small compared to other site's favicons. Looked into it and found that the logo hasn't been cropped. All I did was crop the favicon in this PR. As you can see from the image below (new favicon on the right) it looks much better:

![Screen Shot 2021-03-14 at 1 24 38 PM](https://user-images.githubusercontent.com/43759105/111077749-a1ee3280-84c8-11eb-948d-6101ec1a6f77.jpg)

This has been done to crates.io's favicon as well in rust-lang/crates.io#3411. Thanks, you maintainers! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants