Add liblz4-dev, libsnappy-dev, libzstd-dev #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
force-pushed
the
orcxx-deps
branch
2 times, most recently
from
d87e299
to
1d8ccb9
Compare
They are needed to compile 'orcxx'
syphar
approved these changes
Aug 8, 2023
|
hank you for the contribution! please note that we have to manually deploy the image to our build-server, which I'm doing roughly once a week. ( perhaps I can do it later today, have to check my schedule). Don't hesitate to ping me if it takes too long. |
|
@progval the new image is deployed now, I also queued a new rebuild for the most recent version of both crates (0.2.0) |
Merged
|
Thanks! I'm afraid I haven't got it completely right, it still needs #135 and I'll have a fix in 0.2.1 to actually search for system libs. (I'm vendoring a C++ library, and by default it downloads its own dependencies itself...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are needed to compile 'orcxx' and 'orcxx_derive': https://docs.rs/crate/orcxx/0.1.0/builds/880112
Thanks!