Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around search not updating the index #301

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Work around search not updating the index #301

merged 3 commits into from
Sep 5, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Sep 4, 2018

@pietroalbini
Copy link
Member

cargo install lazy_static rightfully fails because there are no lazy_static binaries. You need to ignore the error. LGTM otherwise.

@pietroalbini
Copy link
Member

Rustfmt error (remove the trailing whitespace in the comment at line 172).

@Eh2406
Copy link
Contributor Author

Eh2406 commented Sep 4, 2018

Sorry doing this PR using the github editor.

@pietroalbini
Copy link
Member

Still failing rustfmt :(

@Eh2406
Copy link
Contributor Author

Eh2406 commented Sep 4, 2018

Tried again this time doing only what it says it wants.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Sep 5, 2018

and we are green

@pietroalbini pietroalbini merged commit eaa481a into rust-lang:master Sep 5, 2018
@pietroalbini
Copy link
Member

Thanks!

@lnicola lnicola mentioned this pull request May 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eh2406 @pietroalbini