This repository has been archived by the owner on May 21, 2019. It is now read-only.
Use platform-independent preprocessor macros for sparc64 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparc64 has different preprocessor definitons that can be used to detect the platform. There is __sparc64__, __sparcv9 and __sparc_v9__. However, all of them are defined only on one of the three targets BSD, Solaris and Linux. A cross-platform way to detect sparc64 is testing whether both __sparc__ and __arch64__ is defined which is available on all three targets.
|
Sure! |
jrtc27
reviewed
Oct 25, 2017
| @@ -89,7 +89,7 @@ | |||
| * Presumably it's any version of GCC, and targeting an arch that | |||
| * does not have dedicated bit counting instructions. | |||
| */ | |||
| #if (defined(__sparc64__) || defined(__sparcv9) || defined(__mips_n64) || defined(__mips_o64) || defined(__riscv__) \ | |||
| #if ((defined(__sparc__) || defined(__arch64__)) || defined(__mips_n64) || defined(__mips_o64) || defined(__riscv__) \ | |||
There was a problem hiding this comment.
Shouldn’t that be &&? Though I wonder whether 32-bit SPARC would also need it and thus if the defined(__arch64__) can be dropped...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sparc64 has different preprocessor definitons that can be used to detect the platform. There is
__sparc64__,__sparcv9and__sparc_v9__. However, all of them are defined only on one of the three targets BSD, Solaris and Linux. A cross-platform way to detect sparc64 is testing whether both__sparc__and__arch64__is defined which is available on all three targets.Solaris:
Linux:
I don't have a BSD at hand right now, but I know from the Firefox sources that BSD uses
__sparc__and__arch64__as well. See https://bugzilla.mozilla.org/show_bug.cgi?id=953211#c5 for reference.This addresses rust-lang/rust#45487.