-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable f16
for LoongArch64
#722
Conversation
Disable `f161` for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures in `testcrate/tests/conv.rs`. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20.
Do tests pass if you only disable FFI calls here compiler-builtins/testcrate/build.rs Lines 55 to 66 in d4a3955
|
No, they are still failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking, I updated the comment but this lgtm
If you need it in rust-lang/rust, this is released in 0.1.138 https://github.com/rust-lang/compiler-builtins/releases/tag/compiler_builtins-v0.1.138. Will probably be a few days before we can bump to that version since a few builtins updates are already queued. |
Disable
f161
for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures intestcrate/tests/conv.rs
. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20.