Fix math libraries not being linked on some platforms #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amjad50
force-pushed
the
fix_libm_weak_link
branch
from
75eb6ec to
00baf68
Compare
|
Rather than messing with clippy attributes, just disable it in CI for now. Though this should be fixed properly by updating the |
|
Updated libm |
This is a continuation/fix of 018616e. In that commit, we made it add the math functions to all platforms (except apple-targets and windows), and use `weak` linking, so that it can be used if the system doesn't have those functions. Didn't notice `mod math` was behind another set of `cfg`, so removed it as well here.
The solution is not pretty, but not sure why we still get clippy warning from one of the files in `libm` even though we use `allow(clippy::all)`
Amanieu
force-pushed
the
fix_libm_weak_link
branch
from
acee57a to
dd85395
Compare
|
Oops sorry for the noise. I accidentally tapped a button when scrolling on mobile. Hopefully I undid my mistake. |
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
Jun 18, 2024
In <rust-lang#594>, symbols for the Rust port of libm were made always weakly available. This seems to be causing problems on platforms with ABI issues, as explained at <rust-lang/rust#125016 (comment)>. Disable Rust libm on x86 without sse2 to mitigate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation/fix of 018616e. In that commit, we made it add the math functions to all platforms (except apple-targets and windows), and use
weaklinking, so that it can be used if the system doesn't have those functions.Didn't notice
mod mathwas behind another set ofcfg, so removed it as well here.There is an issue with clippy, so disabled it on the file as a whole