Skip to content

Commit

Permalink
Update to release_60 of LLVM's compiler-rt
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexcrichton
alexcrichton committed Jan 25, 2018
1 parent 0a95675 commit 3454479
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "compiler-rt/compiler-rt-cdylib/compiler-rt"]
[submodule "compiler-rt"]
path = compiler-rt
url = https://github.com/rust-lang/compiler-rt
2 changes: 1 addition & 1 deletion compiler-rt
Submodule compiler-rt updated 1540 files

5 comments on commit 3454479

@glaubitz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the workaround from rust-lang/compiler-rt#35 got lost during this update.

The fix has landed upstream https://reviews.llvm.org/D42902 but is still incorrect for sparc64 and riscv32: https://reviews.llvm.org/D43146.

@alexcrichton What can we do to re-add the workaround until it has been resolved upstream completely? I cannot find which branch I would have to open a PR for to get this issue resolved again.

@alexcrichton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Egad sorry about that!

I think you can make a PR to this repository, however, which updates the submodule, right?

@glaubitz
Copy link

@glaubitz glaubitz commented on 3454479 May 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make a PR to this repository, however, which updates the submodule, right?

Not sure. I'll give it a try. I tried first to create a PR against https://github.com/rust-lang/compiler-rt/tree/dfd960b5f1a1751b22738fa34fd27b583f4618db but that didn't work.

@alexcrichton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent a PR to #242

@glaubitz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Please sign in to comment.