-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake restart fix v2 #101
base: master
Are you sure you want to change the base?
Cmake restart fix v2 #101
Conversation
I faced with this problem on macOS, where |
the current release of tokio-tungstenite contains all suitable fixes add notes about hyperium/http#422 rust-lang/cmake-rs#96 rust-lang/cmake-rs#101
@alexcrichton , have no time to review, or have some doubts about this PR? |
First off, I want to say I'm sorry for being so glacially slow on this PR, I got too used to this email sitting in my inbox. Other than that though I'm reading this over and this looks pretty reasonable to me, thanks for sending this PR and doing the work here! Code-wise I was wondering if perhaps Again I'm sorry about the pace here, but I'll do my best to be more responsive on this in the future! |
6518357
to
b879aac
Compare
refactor these two into run_cmake_action function
Also I removed unfinished sentence in comment Plus rebase. |
Ping @alexcrichton |
f1ce096
to
7ece076
Compare
7ece076
to
285d900
Compare
I rebased my branch, it is again ready to merge @alexcrichton |
Sorry I think I'm gonna be real with myself, I don't have time to maintain this crate any more. I've opened #127. |
fad72bd
to
a97e526
Compare
a97e526
to
743ddfa
Compare
Rebase on master. |
743ddfa
to
dfa2f23
Compare
Extracted from comments that I add to cmake-rs:
// Acording to
// https://gitlab.kitware.com/cmake/cmake/-/issues/18959
// CMake does not support usage of the same build directory for different
// compilers. The problem is that we can not make sure that we use the same compiler
// before running of CMake without CMake's logic duplication (for example consider
// usage of CMAKE_TOOLCHAIN_FILE). Fortunately for us, CMake can detect is
// compiler changed by itself. This is done for interactive CMake's configuration,
// like ccmake/cmake-gui. But after compiler change CMake resets all cached variables.
// So
run cmake twice with parameters specified by user of
cmake-rs
to make sure thatsettings not disappear. Tested on macOS during several weeks. As I found out the problem that I faced in #98 ,
is unrelated to this patch, and related to rust-lang/cc-rs#530 , but I made little changes of the implementation
to make it more robust.