Update windows-bindgen dependency
#1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
approved these changes
Jan 7, 2025
Comment on lines
+73
to
+90
| pub type HINSTANCE = *mut core::ffi::c_void; | ||
| pub type HKEY = *mut core::ffi::c_void; | ||
| pub const HKEY_LOCAL_MACHINE: HKEY = -2147483646i32 as _; | ||
| pub type HMODULE = *mut core::ffi::c_void; | ||
| pub type HRESULT = i32; | ||
| pub type IMAGE_FILE_MACHINE = u16; | ||
| pub const IMAGE_FILE_MACHINE_AMD64: IMAGE_FILE_MACHINE = 34404u16; | ||
| pub const IID_IUnknown: GUID = GUID::from_u128(0x00000000_0000_0000_c000_000000000046); | ||
| #[repr(C)] | ||
| pub struct IUnknown_Vtbl { | ||
| pub QueryInterface: unsafe extern "system" fn( | ||
| this: *mut core::ffi::c_void, | ||
| iid: *const GUID, | ||
| interface: *mut *mut core::ffi::c_void, | ||
| ) -> HRESULT, | ||
| pub AddRef: unsafe extern "system" fn(this: *mut core::ffi::c_void) -> u32, | ||
| pub Release: unsafe extern "system" fn(this: *mut core::ffi::c_void) -> u32, | ||
| } |
There was a problem hiding this comment.
Nit: I wonder why these are added?
There was a problem hiding this comment.
The metadata used to described HMODULE - required by FreeLibrary and friends - actually depends on HINSTANCE.
Similarly, CoCreateInstance depends on IUnknown.
This is what I meant by the following in the PR description:
There are a handful of additional types in the output. Those reflect a more complete representation of the requested filters and their dependencies.
The bindgen crate doesn't know whether you actually need these dependencies but it includes them as there are cases where they are definitely required.
There was a problem hiding this comment.
Ah, thanks for the detailed explanation!
madsmtm
added
dependencies
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
cccrate to use the latest version of thewindows-bindgencrate.https://github.com/microsoft/windows-rs/releases/tag/0.61.0
A few notes worth mentioning about this change:
bindgenarguments have been simplified and I've updated them to produce the same form of output.--etcoption can be used to avoid having to parse the filter file yourself.Here's more detailed information on the latest version of the
windows-bindgencrate:microsoft/windows-rs#3359
Adding @ChrisDenton as he originally came up with this model for the Rust project. I figure you'll be updating the bindings for the Rust compiler/library yourself so I thought I'd take a stab at this smaller project.