Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm32-wasip1-threads: shared-memory disallowed due to not compiled with 'atomics' or 'bulk-memory' features #1221

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

NobodyXu
Copy link
Collaborator

Fixed #1217

@NobodyXu NobodyXu force-pushed the fix/wasm32-wasip1-threads branch 7 times, most recently from f7d3c9e to ae62d29 Compare September 30, 2024 12:48
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu marked this pull request as ready for review September 30, 2024 13:49
@NobodyXu
Copy link
Collaborator Author

cc @oligamiq opened this PR which should fix your compilation error

@NobodyXu NobodyXu merged commit 94ca4d3 into main Oct 1, 2024
54 checks passed
@NobodyXu NobodyXu deleted the fix/wasm32-wasip1-threads branch October 1, 2024 09:47
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for wasm32-wasip1-threads
1 participant