Optimize jobserver try_acquire
#1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
First try `jobserver::Client::try_acquire`, which will work:
- If a fifo is used as jobserver
- On linux and:
- preadv2 with non-blocking read available (>=5.6)
- /proc is available
- On Windows
- On wasm
if not, we will simply fallback to help thread implementation, spawning one
thread to maintain compatibility with other platforms.
Signed-off-by: Jiahao XU <[email protected]>
Also impls `Send`, `Sync`, `RefUnwindSafe` and `UnwindSafed` when the `T` meets the criterior. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
whenever feature parallel is enabled. Signed-off-by: Jiahao XU <[email protected]>
There is no need to, it never fails. Signed-off-by: Jiahao XU <[email protected]>
|
I do not believe it is acceptable to vendor OnceLock. It is a bad idea for a low-maintenance crate to vendor code that may need a security update. |
Thanks for pointing out, under @the8472 's advice, I've replaced that with once_cell dependency and removed the vendoring of OnceLock. |
BurntSushi
added a commit
to BurntSushi/ripgrep
that referenced
this pull request
Apr 23, 2024
Notably, this removes winapi in favor of windows-sys, as a result of winapi-util switching over to windows-sys[1]. Annoyingly, when PCRE2 is enabled, this brings in a dependency on `once_cell`[2]. I had worked to remove it from my dependencies and now it's back. Gah. I suppose I could disable the `parallel` feature of `cc`, but that doesn't seem like a good trade-off. [1]: BurntSushi/winapi-util#13 [2]: rust-lang/cc-rs#1037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try
jobserver::Client::try_acquire(available on jobserver 1.0.29), which will work:if not, we will simply fallback to help thread implementation, spawning one
thread to maintain compatibility with other platforms.