Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't give a hard error when the end-user specifies RUSTC_BOOTSTRAP=crate_name #9365

Merged
merged 5 commits into from
Apr 21, 2021
Merged

Don't give a hard error when the end-user specifies RUSTC_BOOTSTRAP=crate_name #9365

merged 5 commits into from
Apr 21, 2021

Commits on Apr 17, 2021

  1. Don't give a hard error on RUSTC_BOOTSTRAP=crate_name

    @jyn514
    jyn514 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    04fa2f2 View commit details
    Browse the repository at this point in the history

  2. Use the crate name instead of the package name 

    This doesn't work because it uses the name of the build script, which is
always build_script_build. I'm not sure what to change it to - the name
of the library crate could be different than the name of the package,
and there could be multiple different crates being compiled in the same
package.
    @jyn514
    jyn514 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    6d6f466 View commit details
    Browse the repository at this point in the history

  3. Use the library name to decide whether the override should be allowed… 

    … from the top-level.

If there's no library, give a hard error unless features are
unconditionally allowed with RUSTC_BOOTSTRAP=1.
    @jyn514
    jyn514 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    236fe87 View commit details
    Browse the repository at this point in the history

  4. minor cleanup

    @jyn514
    jyn514 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    1b36ddc View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @jyn514
    jyn514 committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    5a71496 View commit details
    Browse the repository at this point in the history