Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of --message-format taking multiple values #9173

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

casey
Copy link
Contributor

@casey casey commented Feb 14, 2021

I tried passing multiple values to --message-format, as is mentioned in the docs, and it didn't work:

$ cargo test --message-format human,json
error: cannot specify two kinds of `message-format` arguments
$ cargo test --message-format human --message-format json
error: cannot specify two kinds of `message-format` arguments

It's entirely possible I misunderstood the docs, but just in case I didn't, I thought I'd open this PR to remove the bit that mentions that the flag accepts multiple values.

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2021
@ehuss
Copy link
Contributor

ehuss commented Feb 14, 2021

Thanks for bringing this up! So, it does support multiple arguments, but only the json- prefixed ones. The code is here. Would you be willing to just extend the documentation to clarify that the multiple arguments only apply to the json fields, and that the json settings can't be combined with human and short?

Also, when updating the source for the man pages, they need to be rebuilt and the changes committed. The documentation for that is here.

@casey
Copy link
Contributor Author

casey commented Feb 15, 2021

Thanks for bringing this up! So, it does support multiple arguments, but only the json- prefixed ones. The code is here.

Ah, I see.

Would you be willing to just extend the documentation to clarify that the multiple arguments only apply to the json fields, and that the json settings can't be combined with human and short?

I wasn't entirely sure how to best summarize this, because the rules are a little complicated, so I clarified what could be combined in the documentation for each value.

Also, when updating the source for the man pages, they need to be rebuilt and the changes committed. The documentation for that is here.

Done!

@ehuss
Copy link
Contributor

ehuss commented Feb 15, 2021

Looks good, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 15, 2021

📌 Commit d174b77 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2021
@bors
Copy link
Contributor

bors commented Feb 15, 2021

⌛ Testing commit d174b77 with merge 3e25c9d...

@bors
Copy link
Contributor

bors commented Feb 15, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 3e25c9d to master...

@bors bors merged commit 3e25c9d into rust-lang:master Feb 15, 2021
@casey casey deleted the patch-2 branch February 15, 2021 22:21
@casey
Copy link
Contributor Author

casey commented Feb 15, 2021

Thanks for merging!

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 19, 2021
Update cargo

8 commits in ab64d1393b5b77c66b6534ef5023a1b89ee7bf64..bf5a5d5e5d3ae842a63bfce6d070dfd438cf6070
2021-02-10 00:19:10 +0000 to 2021-02-18 15:49:14 +0000
- Propagate `lto=off` harder (rust-lang/cargo#9182)
- refactor: make deref intentions more straightforward (rust-lang/cargo#9183)
- Update link for no_std attribute. (rust-lang/cargo#9174)
- Remove mention of --message-format taking multiple values (rust-lang/cargo#9173)
- Emit warning on env variable case mismatch (rust-lang/cargo#9169)
- Implement Rustdoc versioning checks (rust-lang/cargo#8640)
- Bump to 0.53.0, update changelog (rust-lang/cargo#9168)
- Prevent testsuite from loading config out of sandbox. (rust-lang/cargo#9164)
@ehuss ehuss added this to the 1.52.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants