Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable section of cargo/config.toml takes bools #9057

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Jan 8, 2021

At least according to a quick local test, those should not be strings, but booleans! With the following cargo config:

[unstable]
mtime-on-use = 'yes'

I get the following cargo output:

error: error in /root/builds/hlab/isengard/agent-rust/.cargo_cache/config: `unstable.mtime-on-use` expected true/false, but found a string

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

📌 Commit 287714f has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2021
@bors
Copy link
Collaborator

bors commented Jan 8, 2021

⌛ Testing commit 287714f with merge 181a4a8b47f61ae4ed03469c62ebfd4d7639be3c...

@alexcrichton
Copy link
Member

@bors: r-

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2021
@roblabla
Copy link
Contributor Author

roblabla commented Jan 8, 2021

Nice catch! Fixed.

@ehuss
Copy link
Contributor

ehuss commented Jan 8, 2021

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

📌 Commit 203aac4 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jan 8, 2021
@bors
Copy link
Collaborator

bors commented Jan 8, 2021

⌛ Testing commit 203aac4 with merge faf05ac...

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing faf05ac to master...

@bors bors merged commit faf05ac into rust-lang:master Jan 8, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2021
Update cargo

10 commits in 329895f5b52a358e5d9ecb26215708b5cb31d906..a73e5b7d567c3036b296fc6b33ed52c5edcd882e
2021-01-06 00:01:52 +0000 to 2021-01-12 23:45:39 +0000
- Sort available binaries when multiple (rust-lang/cargo#9066)
- Fix misspelling of environment variable (rust-lang/cargo#9067)
- Remove statement that opt-level 0 turns on debug (rust-lang/cargo#9070)
- Fix `links` vars showing up for testing packages (rust-lang/cargo#9065)
- Fix unit_for computation on proc-macros in shared workspace. (rust-lang/cargo#9059)
- Document `could not find the github team` error on `cargo owner --add` (rust-lang/cargo#9000)
- Unstable section of cargo/config.toml takes bools (rust-lang/cargo#9057)
- [doc] add note about empty environment variables for missing manifest keys (rust-lang/cargo#9053)
- another round of clippy lint fixes (rust-lang/cargo#9051)
- Updated display message of cargo metadata --help (rust-lang/cargo#9050)
@ehuss ehuss added this to the 1.51.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants