Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of almost fresh builds #8837

Merged
merged 5 commits into from
Nov 11, 2020
Merged

Improve performance of almost fresh builds #8837

merged 5 commits into from
Nov 11, 2020

Commits on Nov 10, 2020

  1. Don't spawn a new thread for fresh jobs 

    The overhead in doing so is often much higher than the actual time it
takes to execute the job
    @bjorn3
    bjorn3 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    0c5f6f0 View commit details
    Browse the repository at this point in the history

  2. Split Job::new into Job::new_fresh and Job::new_dirty

    @bjorn3
    bjorn3 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    3836dfb View commit details
    Browse the repository at this point in the history

  3. [HACK] Fix deadlock by avoiding backpressure for fresh jobs

    @bjorn3
    bjorn3 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    49b63b7 View commit details
    Browse the repository at this point in the history

  4. Immediately print job output for fresh jobs 

    This prevents a deadlock where the message queue is filled with output
messages but not emptied as the job producing the messages runs on the
same thread as the message processing.
    @bjorn3
    bjorn3 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    0583081 View commit details
    Browse the repository at this point in the history

  5. Add some comments

    @bjorn3
    bjorn3 committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    50c0221 View commit details
    Browse the repository at this point in the history