Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try installing exact versions before updating #8022

Merged
merged 20 commits into from
May 20, 2020

Commits on Mar 20, 2020

  1. Configuration menu
    Copy the full SHA
    e8b0344 View commit details
    Browse the repository at this point in the history
  2. Try installing exact versions before updating

    When an exact version is being installed, if we already have that
    version from the index, we don't need to update the index before
    installing it. Don't do this if it's not an exact version, because the
    update may find us a newer version.
    
    This is particularly useful for scripts which unconditionally run
    `cargo install some-crate --version=1.2.3`. Before install-update, I
    wrote a crate to do this
    (https://crates.io/crates/cargo-ensure-installed) which I'm trying to
    replace with just `cargo install`, but the extra latency of updating the
    index for a no-op is noticeable.
    
    This introduces an interesting edge-case around yanked crates; the
    yanked-ness of crates will no longer change on install for exact version
    matches which were already downloaded. This feels niche enough to
    hopefully not matter...
    illicitonion committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    a721e62 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Configuration menu
    Copy the full SHA
    137e518 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    598183e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e2c233 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2020

  1. Review comments

    illicitonion committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    14e3e41 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c96c05 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Commenty review comments

    illicitonion committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    7a83d61 View commit details
    Browse the repository at this point in the history
  2. select_pkg takes a Dependency not name + vers

    Handling of these is coupled, so do the handling in one place, close to
    where we parse the command line flags, so we can just pass in a single
    derived object.
    illicitonion committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    6eef9a8 View commit details
    Browse the repository at this point in the history
  3. select_pkg takes Dependency _or_ list_all not both

    It only ever actually uses one, so let's reflect that in the types.
    illicitonion committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    bf6a627 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0a38196 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7b8d9b3 View commit details
    Browse the repository at this point in the history
  6. Add a little docstring

    illicitonion committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    4432ac3 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Configuration menu
    Copy the full SHA
    ad065e7 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Configuration menu
    Copy the full SHA
    624ce68 View commit details
    Browse the repository at this point in the history
  2. Simplify

    Remove enum, pull out function and dependent function
    illicitonion committed May 2, 2020
    Configuration menu
    Copy the full SHA
    d2b2775 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d1c6a7 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Configuration menu
    Copy the full SHA
    18ceb9f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Configuration menu
    Copy the full SHA
    8064909 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Switch to using existing is_locked implementation

    semver hasn't merged the upstream PR (yet)
    illicitonion committed May 20, 2020
    Configuration menu
    Copy the full SHA
    b719272 View commit details
    Browse the repository at this point in the history