-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try installing exact versions before updating #8022
Merged
Merged
Commits on Mar 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e8b0344 - Browse repository at this point
Copy the full SHA e8b0344View commit details -
Try installing exact versions before updating
When an exact version is being installed, if we already have that version from the index, we don't need to update the index before installing it. Don't do this if it's not an exact version, because the update may find us a newer version. This is particularly useful for scripts which unconditionally run `cargo install some-crate --version=1.2.3`. Before install-update, I wrote a crate to do this (https://crates.io/crates/cargo-ensure-installed) which I'm trying to replace with just `cargo install`, but the extra latency of updating the index for a no-op is noticeable. This introduces an interesting edge-case around yanked crates; the yanked-ness of crates will no longer change on install for exact version matches which were already downloaded. This feels niche enough to hopefully not matter...
Configuration menu - View commit details
-
Copy full SHA for a721e62 - Browse repository at this point
Copy the full SHA a721e62View commit details
Commits on Mar 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 137e518 - Browse repository at this point
Copy the full SHA 137e518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 598183e - Browse repository at this point
Copy the full SHA 598183eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e2c233 - Browse repository at this point
Copy the full SHA 1e2c233View commit details
Commits on Mar 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 14e3e41 - Browse repository at this point
Copy the full SHA 14e3e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c96c05 - Browse repository at this point
Copy the full SHA 3c96c05View commit details
Commits on Apr 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7a83d61 - Browse repository at this point
Copy the full SHA 7a83d61View commit details -
select_pkg takes a Dependency not name + vers
Handling of these is coupled, so do the handling in one place, close to where we parse the command line flags, so we can just pass in a single derived object.
Configuration menu - View commit details
-
Copy full SHA for 6eef9a8 - Browse repository at this point
Copy the full SHA 6eef9a8View commit details -
select_pkg takes Dependency _or_ list_all not both
It only ever actually uses one, so let's reflect that in the types.
Configuration menu - View commit details
-
Copy full SHA for bf6a627 - Browse repository at this point
Copy the full SHA bf6a627View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a38196 - Browse repository at this point
Copy the full SHA 0a38196View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b8d9b3 - Browse repository at this point
Copy the full SHA 7b8d9b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4432ac3 - Browse repository at this point
Copy the full SHA 4432ac3View commit details
Commits on Apr 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ad065e7 - Browse repository at this point
Copy the full SHA ad065e7View commit details
Commits on May 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 624ce68 - Browse repository at this point
Copy the full SHA 624ce68View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2b2775 - Browse repository at this point
Copy the full SHA d2b2775View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d1c6a7 - Browse repository at this point
Copy the full SHA 9d1c6a7View commit details
Commits on May 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 18ceb9f - Browse repository at this point
Copy the full SHA 18ceb9fView commit details
Commits on May 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8064909 - Browse repository at this point
Copy the full SHA 8064909View commit details
Commits on May 20, 2020
-
Switch to using existing is_locked implementation
semver hasn't merged the upstream PR (yet)
Configuration menu - View commit details
-
Copy full SHA for b719272 - Browse repository at this point
Copy the full SHA b719272View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.