Stabilize Alternative Registries #6654

ehuss · 2019-02-11T23:47:27Z

This includes a few minor changes besides stabilizing:

cargo search won't display crates.io search URL for extra results for non-crates.io registries.
Document using environment variables for API tokens.
Explicit section in config.md for documenting the credentials file.

Closes rust-lang/rust#44931
Closes rust-lang/crates-io-cargo-teams#21
Closes #6589
Closes #4688

alexcrichton

This all looks fantastic to me, just a few minor nits. Thanks again so much for all your work here @ehuss!

alexcrichton · 2019-02-12T13:40:42Z

src/cargo/util/toml/mod.rs

            let registry_id = SourceId::alt_registry(cx.config, registry)?;
            dep.set_registry_id(registry_id);
        }
        if let Some(registry_index) = &self.registry_index {
-            cx.features.require(Feature::alternative_registries())?;


technically speaking we don't have to delete this code, but also technically speaking there's no reason to keep the code around!

alexcrichton · 2019-02-12T13:41:50Z

src/doc/man/options-token.adoc

+The token for crates.io may be specified with the `CARGO_REGISTRY_TOKEN`
+environment variable. Tokens for other registries may be specified with
+environment variables of the form `CARGO_REGISTRIES_NAME_TOKEN` where `NAME`
+is the name of the registry in all capital letters.


I wonder if this could perhaps mention that the env vars are derived from the .cargo/config configuration to ensure both mechanisms are mentioned here?

alexcrichton · 2019-02-12T13:45:43Z

src/doc/src/reference/registries.md

+token = "854DvwSlUwEHtIo3kWy6x7UCPKHfzCmy"
+```
+
+### Running a Registry


Could some text be added to this section along the lines of:

There's no widely used piece of software used to run your own registry

We are, however, very interested in documenting those which crop up

We're also interested in documenting integration with existing package caches once they have crates.io support

alexcrichton · 2019-02-12T19:47:34Z

@bors: r+

bors · 2019-02-12T19:47:37Z

📌 Commit 902885c has been approved by alexcrichton

bors · 2019-02-12T19:47:46Z

⌛ Testing commit 902885c with merge 2e4cfc2...

Stabilize Alternative Registries This includes a few minor changes besides stabilizing: - `cargo search` won't display `crates.io` search URL for extra results for non-crates.io registries. - Document using environment variables for API tokens. - Explicit section in `config.md` for documenting the credentials file. Closes rust-lang/rust#44931 Closes rust-lang/crates-io-cargo-teams#21 Closes #6589 Closes #4688

bors · 2019-02-12T20:36:03Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 2e4cfc2 to master...

ninrod · 2019-02-12T21:46:55Z

this seems great. So can I use rust with artifactory now?

nbigaouette-eai · 2019-02-20T20:23:48Z

For artifactory support, please vote for the feature request here: https://www.jfrog.com/jira/browse/RTFACT-13469

przygienda · 2019-02-21T05:51:12Z

yeah ! ;-)

Update cargo 9 commits in 865cb70106a6b1171a500ff68f93ab52eea56e72..b33ce7fc9092962b0657b4c25354984b5e5c47e4 2019-02-10 15:49:37 +0000 to 2019-02-19 18:42:50 +0000 - Don't retry invalid credentials from git credential helpers (rust-lang/cargo#6681) - Fix some typos in resolver tests (rust-lang/cargo#6682) - Add an unstable option to build proc macros for both the host and the target (rust-lang/cargo#6547) - Test cases proving RUSTC_WRAPPER can be a relative path (rust-lang/cargo#6638) - Add support for Azure DevOps (rust-lang/cargo#6264) - Update docs for removed `patch` restriction. (rust-lang/cargo#6663) - Fix incorrect help message (rust-lang/cargo#6555) - Stabilize Alternative Registries (rust-lang/cargo#6654) - Having a [patch] section when publishing is not an error (rust-lang/cargo#6535)

Pkgsrc changes: * Bump required rust version to build to 1.33.0. * Adapt patches to changed file locations. * (I worry about 32-bit ports, now that Atomic64 apparently is First-Class; this has been built on NetBSD/amd64 so far) Upstream changes: Version 1.34.0 (2019-04-11) ========================== Language -------- - [You can now use `#[deprecated = "reason"]`][58166] as a shorthand for `#[deprecated(note = "reason")]`. This was previously allowed by mistake but had no effect. - [You can now accept token streams in `#[attr()]`,`#[attr[]]`, and `#[attr{}]` procedural macros.][57367] - [You can now write `extern crate self as foo;`][57407] to import your crate's root into the extern prelude. Compiler -------- - [You can now target `riscv64imac-unknown-none-elf` and `riscv64gc-unknown-none-elf`.][58406] - [You can now enable linker plugin LTO optimisations with `-C linker-plugin-lto`.][58057] This allows rustc to compile your Rust code into LLVM bitcode allowing LLVM to perform LTO optimisations across C/C++ FFI boundaries. - [You can now target `powerpc64-unknown-freebsd`.][57809] Libraries --------- - [The trait bounds have been removed on some of `HashMap<K, V, S>`'s and `HashSet<T, S>`'s basic methods.][58370] Most notably you no longer require the `Hash` trait to create an iterator. - [The `Ord` trait bounds have been removed on some of `BinaryHeap<T>`'s basic methods.][58421] Most notably you no longer require the `Ord` trait to create an iterator. - [The methods `overflowing_neg` and `wrapping_neg` are now `const` functions for all numeric types.][58044] - [Indexing a `str` is now generic over all types that implement `SliceIndex<str>`.][57604] - [`str::trim`, `str::trim_matches`, `str::trim_{start, end}`, and `str::trim_{start, end}_matches` are now `#[must_use]`][57106] and will produce a warning if their returning type is unused. - [The methods `checked_pow`, `saturating_pow`, `wrapping_pow`, and `overflowing_pow` are now available for all numeric types.][57873] These are equivalvent to methods such as `wrapping_add` for the `pow` operation. Stabilized APIs --------------- #### std & core * [`Any::type_id`] * [`Error::type_id`] * [`atomic::AtomicI16`] * [`atomic::AtomicI32`] * [`atomic::AtomicI64`] * [`atomic::AtomicI8`] * [`atomic::AtomicU16`] * [`atomic::AtomicU32`] * [`atomic::AtomicU64`] * [`atomic::AtomicU8`] * [`convert::Infallible`] * [`convert::TryFrom`] * [`convert::TryInto`] * [`iter::from_fn`] * [`iter::successors`] * [`num::NonZeroI128`] * [`num::NonZeroI16`] * [`num::NonZeroI32`] * [`num::NonZeroI64`] * [`num::NonZeroI8`] * [`num::NonZeroIsize`] * [`slice::sort_by_cached_key`] * [`str::escape_debug`] * [`str::escape_default`] * [`str::escape_unicode`] * [`str::split_ascii_whitespace`] #### std * [`Instant::checked_add`] * [`Instant::checked_sub`] * [`SystemTime::checked_add`] * [`SystemTime::checked_sub`] Cargo ----- - [You can now use alternative registries to crates.io.][cargo/6654] Misc ---- - [You can now use the `?` operator in your documentation tests without manually adding `fn main() -> Result<(), _> {}`.][56470] Compatibility Notes ------------------- - [`Command::before_exec` is now deprecated in favor of the unsafe method `Command::pre_exec`.][58059] - [Use of `ATOMIC_{BOOL, ISIZE, USIZE}_INIT` is now deprecated.][57425] As you can now use `const` functions in `static` variables. [58370]: rust-lang/rust#58370 [58406]: rust-lang/rust#58406 [58421]: rust-lang/rust#58421 [58166]: rust-lang/rust#58166 [58044]: rust-lang/rust#58044 [58057]: rust-lang/rust#58057 [58059]: rust-lang/rust#58059 [57809]: rust-lang/rust#57809 [57873]: rust-lang/rust#57873 [57604]: rust-lang/rust#57604 [57367]: rust-lang/rust#57367 [57407]: rust-lang/rust#57407 [57425]: rust-lang/rust#57425 [57106]: rust-lang/rust#57106 [56470]: rust-lang/rust#56470 [cargo/6654]: rust-lang/cargo#6654 [`Any::type_id`]: https://doc.rust-lang.org/std/any/trait.Any.html#tymethod.type_id [`Error::type_id`]: https://doc.rust-lang.org/std/error/trait.Error.html#tymethod.type_id [`atomic::AtomicI16`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI16.html [`atomic::AtomicI32`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI32.html [`atomic::AtomicI64`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI64.html [`atomic::AtomicI8`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI8.html [`atomic::AtomicU16`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU16.html [`atomic::AtomicU32`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU32.html [`atomic::AtomicU64`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU64.html [`atomic::AtomicU8`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU8.html [`convert::Infallible`]: https://doc.rust-lang.org/std/convert/enum.Infallible.html [`convert::TryFrom`]: https://doc.rust-lang.org/std/convert/trait.TryFrom.html [`convert::TryInto`]: https://doc.rust-lang.org/std/convert/trait.TryInto.html [`iter::from_fn`]: https://doc.rust-lang.org/std/iter/fn.from_fn.html [`iter::successors`]: https://doc.rust-lang.org/std/iter/fn.successors.html [`num::NonZeroI128`]: https://doc.rust-lang.org/std/num/struct.NonZeroI128.html [`num::NonZeroI16`]: https://doc.rust-lang.org/std/num/struct.NonZeroI16.html [`num::NonZeroI32`]: https://doc.rust-lang.org/std/num/struct.NonZeroI32.html [`num::NonZeroI64`]: https://doc.rust-lang.org/std/num/struct.NonZeroI64.html [`num::NonZeroI8`]: https://doc.rust-lang.org/std/num/struct.NonZeroI8.html [`num::NonZeroIsize`]: https://doc.rust-lang.org/std/num/struct.NonZeroIsize.html [`slice::sort_by_cached_key`]: https://doc.rust-lang.org/std/slice/fn.sort_by_cached_key [`str::escape_debug`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_debug [`str::escape_default`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_default [`str::escape_unicode`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_unicode [`str::split_ascii_whitespace`]: https://doc.rust-lang.org/std/primitive.str.html#method.split_ascii_whitespace [`Instant::checked_add`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_add [`Instant::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_sub [`SystemTime::checked_add`]: https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_add [`SystemTime::checked_sub`]: https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_sub

ehuss added 5 commits January 23, 2019 15:13

Document registries.

3229b01

Update for review comments.

8b27a7b

Clarify behavior of Add Owner.

59f27eb

Document registries.

0a962f2

Stabilize Alternative Registries

737382d

ehuss mentioned this pull request Feb 11, 2019

Document registries. #6594

Closed

ehuss added the relnotes Release-note worthy label Feb 11, 2019

alexcrichton approved these changes Feb 12, 2019

View reviewed changes

Update for review comments.

902885c

alexcrichton mentioned this pull request Feb 12, 2019

Alternative Registries Stabilization Proposal #6589

Closed

bors merged commit 902885c into rust-lang:master Feb 12, 2019

bors mentioned this pull request Feb 12, 2019

HTTPS all the things #6614

Merged

ehuss mentioned this pull request Feb 20, 2019

Update cargo rust-lang/rust#58584

Merged

ehuss mentioned this pull request Mar 25, 2019

alternative registries stabilization rust-lang/crates-io-cargo-teams#21

Closed

4 tasks

ehuss added this to the 1.34.0 milestone Feb 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize Alternative Registries #6654

Stabilize Alternative Registries #6654

ehuss commented Feb 11, 2019

alexcrichton left a comment

alexcrichton Feb 12, 2019

alexcrichton Feb 12, 2019

alexcrichton Feb 12, 2019

alexcrichton commented Feb 12, 2019

bors commented Feb 12, 2019

bors commented Feb 12, 2019

bors commented Feb 12, 2019

ninrod commented Feb 12, 2019

nbigaouette-eai commented Feb 20, 2019

przygienda commented Feb 21, 2019

Stabilize Alternative Registries #6654

Stabilize Alternative Registries #6654

Conversation

ehuss commented Feb 11, 2019

alexcrichton left a comment

Choose a reason for hiding this comment

alexcrichton Feb 12, 2019

Choose a reason for hiding this comment

alexcrichton Feb 12, 2019

Choose a reason for hiding this comment

alexcrichton Feb 12, 2019

Choose a reason for hiding this comment

alexcrichton commented Feb 12, 2019

bors commented Feb 12, 2019

bors commented Feb 12, 2019

bors commented Feb 12, 2019

ninrod commented Feb 12, 2019

nbigaouette-eai commented Feb 20, 2019

przygienda commented Feb 21, 2019