Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to some Rust 2018 idioms #6416

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Migrate to some Rust 2018 idioms #6416

merged 4 commits into from
Dec 11, 2018

Commits on Dec 11, 2018

  1. Start using 2018 idioms in Cargo 

    Remove a number of `extern crate` directives and tweak a number of
imports. Not all `extern crate` is gone yet but this is the bulk of
them!
    @alexcrichton
    alexcrichton committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    9ed82b5 View commit details
    Browse the repository at this point in the history

  2. Run cargo fix --edition-idioms and fixup output 

    This gets Cargo passing the `--edition-idioms` lints and more down the
road of the 2018 edition!
    @alexcrichton
    alexcrichton committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    b8b7fae View commit details
    Browse the repository at this point in the history

  3. Turn on Rust 2018 idiom warnings unconditionally 

    It may take us awhile to get used to them, so let's see how this goes!
    @alexcrichton
    alexcrichton committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    92bf2c3 View commit details
    Browse the repository at this point in the history

  4. Reformat after idiom lints

    @alexcrichton
    alexcrichton committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    76ce4df View commit details
    Browse the repository at this point in the history