[beta] fix: Don't back out changes with --broken-code
#6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the behavior of `cargo fix` when the `--broken-code` flag is passed to Cargo. Previously Cargo would always back out automatically applied changes to files whenever the fixed code failed to compile. Now, with the `--broken-code` flag, fixed code is left as-is. This means that if the fixed code can be more easily inspected by humans to detect bugs and such. The main use case intended here is that if you're working with a large code base then lints like the edition idiom lints aren't 100% finished yet to work as smoothly as `cargo fix`. The idiom lints are often useful, however, to transition code to be idiomatic (who would have guessed!) in the new edition. To ease the experience of using not-quite-ready lints this flag can be used to hopefully "fix 90% of lint warnings" and then the remaining compiler errors can be sifted through manually. The intention is that we have edition documentation indicating this workflow which also encourages filing bugs for anything that fails to fix, and hopefully this new behavior will make it easier for us to narrow down what the minimal test case is too!
|
@bors: r+ |
|
📌 Commit 3e746ae has been approved by |
|
⌛ Testing commit 3e746ae with merge c1c6ce5f78287ae234fbaeb7de445417cf6575e6... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Nov 14, 2018
[beta] fix: Don't back out changes with `--broken-code` This is a beta backport of #6312
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beta backport of #6312