Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always rebuild targets when using cargo-fix #5750

Closed

Commits on Jul 24, 2018

  1. Configuration menu
    Copy the full SHA
    e72f9d1 View commit details
    Browse the repository at this point in the history
  2. Touch files before running cargo-fix

    Assume you run `cargo fix` and only get warnings that cannot be fixed.
    Then, without changing the code, you run `cargo fix` again. The compiler
    will see that no files have changed and output… nothing. This is very
    confusing to the end user.
    
    To mitigate this, we now `touch` the entry point files to trick
    rustc/cargo into emitting the same warnings again.
    
    This is a fix but a very "WIP" one for rust-lang#5736
    killercup committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    503db02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    76f872e View commit details
    Browse the repository at this point in the history
  4. Introduce force_rebuild flag in BuildConfig

    And use it for cargo-fix
    killercup committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    d858bf4 View commit details
    Browse the repository at this point in the history
  5. cargo-fix: test with multiple target rebuilds

    Sadly, this doesn't seem to work right now
    killercup committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    1eacc05 View commit details
    Browse the repository at this point in the history
  6. Update tests after rebase

    killercup committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    f29903c View commit details
    Browse the repository at this point in the history
  7. Fix Pascal's stupidity

    Turns out that using test cases that we can actually fix was not a good
    way to test that warnings continue to show up cross runs.
    killercup committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    a54a6cb View commit details
    Browse the repository at this point in the history