Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargotest: purge deps #4429

Merged
merged 1 commit into from
Aug 24, 2017
Merged

cargotest: purge deps #4429

merged 1 commit into from
Aug 24, 2017

Conversation

ishitatsuyuki
Copy link
Contributor

@ishitatsuyuki ishitatsuyuki commented Aug 24, 2017

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ishitatsuyuki ishitatsuyuki changed the title Upload categories specified in the manifest cargotest: purge deps Aug 24, 2017
@matklad
Copy link
Member

matklad commented Aug 24, 2017

Huh, it indeed seems useful to know about unused crates!

Thanks, @ishitatsuyuki !

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2017

📌 Commit 72de74c has been approved by matklad

@bors
Copy link
Contributor

bors commented Aug 24, 2017

⌛ Testing commit 72de74c with merge d516090...

bors added a commit that referenced this pull request Aug 24, 2017
@bors
Copy link
Contributor

bors commented Aug 24, 2017

💔 Test failed - status-travis

@ishitatsuyuki
Copy link
Contributor Author

OSX livelock, please retry.

@matklad
Copy link
Member

matklad commented Aug 24, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Aug 24, 2017

📌 Commit 72de74c has been approved by matklad

@bors
Copy link
Contributor

bors commented Aug 24, 2017

⌛ Testing commit 72de74c with merge 5450163...

bors added a commit that referenced this pull request Aug 24, 2017
@bors
Copy link
Contributor

bors commented Aug 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 5450163 to master...

@bors bors merged commit 72de74c into rust-lang:master Aug 24, 2017
@ehuss ehuss added this to the 1.21.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants