Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unused keys starting with cargo- #2761

Conversation

pwoolcoc
Copy link
Contributor

@pwoolcoc pwoolcoc commented Jun 1, 2016

This change would make it so that cargo does not warn about "unused
keys" for keys that start with cargo-. This could be useful for custom
subcommands that want to be able to read settings from Cargo.toml.

This change would make it so that cargo does not warn about "unused
keys" for keys that start with `cargo-`. This could be useful for custom
subcommands that want to be able to read settings from `Cargo.toml`.
@rust-highfive
Copy link

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@pwoolcoc pwoolcoc changed the title Allow unused keys starting with ``cargo-'' Allow unused keys starting with cargo- Jun 1, 2016
@jonas-schievink
Copy link
Contributor

#2668 implements a similar approach

@alexcrichton
Copy link
Member

Thanks for the PR! Talking about this in the past, however, we've preferred the approach in #2668 to this. Would that suffice for your use case?

@pwoolcoc
Copy link
Contributor Author

pwoolcoc commented Jun 2, 2016

Ah, sorry I hadn't seen that! That will be fine, sorry for the unnecessary PR

@pwoolcoc pwoolcoc closed this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants