Canonicalize CARGO_HOME fallback on Windows #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
@bors r+ |
|
📌 Commit ec6a28c has been approved by |
|
⌛ Testing commit ec6a28c with merge b6e7bf4... |
|
💔 Test failed - cargo-win-msvc-64 |
alexcrichton
force-pushed
the
cargo-env-home
branch
from
ec6a28c
to
165258c
Compare
|
@bors: r=brson 165258c |
|
⌛ Testing commit 165258c with merge 04e1016... |
|
💔 Test failed - cargo-win-msvc-32 |
This commit ensures that we always return the same fallback value on Windows regardless of whichever shell we happen to be run from. We do this by removing the `$HOME` environment variable which `std::env::home_dir` will inspect to force it to fall back to the system APIs. If the old directory exists then we favor that one, but otherwise we favor locations like `C:\Users\$user` Supercedes and closes rust-lang#2604
alexcrichton
force-pushed
the
cargo-env-home
branch
from
165258c
to
ee0b711
Compare
|
@bors: r=brson |
|
📌 Commit ee0b711 has been approved by |
bors
added a commit
that referenced
this pull request
May 13, 2016
Canonicalize CARGO_HOME fallback on Windows This commit ensures that we always return the same fallback value on Windows regardless of whichever shell we happen to be run from. We do this by removing the `$HOME` environment variable which `std::env::home_dir` will inspect to force it to fall back to the system APIs. If the old directory exists then we favor that one, but otherwise we favor locations like `C:\Users\$user` Supercedes and closes #2604
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that we always return the same fallback value on Windows
regardless of whichever shell we happen to be run from. We do this by removing
the
$HOMEenvironment variable whichstd::env::home_dirwill inspect toforce it to fall back to the system APIs. If the old directory exists then we
favor that one, but otherwise we favor locations like
C:\Users\$userSupercedes and closes #2604