Fix caching features across backtracking #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson |
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
In the local loop during resolution all variables need to be reset whenever we backtrack up a frame, but currently the `method` and `features` set are accidentally not reset whenever we backtrack. Calculate the `method` later and cache `features` in each frame so we can properly backtrack. Closes rust-lang#2472
alexcrichton
force-pushed
the
fix-bad-backtrack
branch
from
37ec7ab
to
e3b7f2f
Compare
|
@bors r+ |
|
📌 Commit e3b7f2f has been approved by |
bors
added a commit
that referenced
this pull request
Mar 17, 2016
Fix caching features across backtracking In the local loop during resolution all variables need to be reset whenever we backtrack up a frame, but currently the `method` and `features` set are accidentally not reset whenever we backtrack. Calculate the `method` later and cache `features` in each frame so we can properly backtrack. Closes #2472
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the local loop during resolution all variables need to be reset whenever we
backtrack up a frame, but currently the
methodandfeaturesset areaccidentally not reset whenever we backtrack. Calculate the
methodlater andcache
featuresin each frame so we can properly backtrack.Closes #2472