Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguating docs about when environment variables are set #2419

Merged
merged 1 commit into from
Feb 26, 2016
Merged

Disambiguating docs about when environment variables are set #2419

merged 1 commit into from
Feb 26, 2016

Conversation

anp
Copy link
Member

@anp anp commented Feb 26, 2016

Resolves #2417. I also reorganized the order of the items on the page and moved a little bit of text around. I think it's clearer, but critique is more than welcome.

Providing an example of fetching env vars at runtime in a buildscript.
Reordering the list so that examples pertain to the correct sections.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@anp
Copy link
Member Author

anp commented Feb 26, 2016

r? @alexcrichton

per IRC

@rust-highfive rust-highfive assigned alexcrichton and unassigned wycats Feb 26, 2016
@alexcrichton
Copy link
Member

@bors: r+ 95193ca

Thanks!

@bors
Copy link
Contributor

bors commented Feb 26, 2016

⌛ Testing commit 95193ca with merge 582dcb7...

bors added a commit that referenced this pull request Feb 26, 2016
Resolves #2417. I also reorganized the order of the items on the page and moved a little bit of text around. I think it's clearer, but critique is more than welcome.
@bors
Copy link
Contributor

bors commented Feb 26, 2016

@bors bors merged commit 95193ca into rust-lang:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants