Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env): dont track envs set by cargo in dep-info file #14811

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(env): dont track envs set by cargo in dep-info file #14811

wants to merge 2 commits into from
+164 −2

Commits on Nov 16, 2024

  1. test(env): show rebuild when overriding env set by cargo 

    This is a side effect when fixing 13280 via PR 14701.
    @weihanglo
    weihanglo committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    4f16ebf View commit details
    Browse the repository at this point in the history

  2. fix(env): dont track envs set by cargo in dep-info file 

    This patch is quite hacky since the "set-by-Cargo" env vars are
hardcoded. However, not all environment variables set by Cargo are
statically known. To prevent the actual environment variables applied to
rustc invocation get out of sync from what we hard-code, a debug time
assertion is put to help discover missing environment variables earlier.
    @weihanglo
    weihanglo committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    45a4e98 View commit details
    Browse the repository at this point in the history