Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow build scripts to report error messages through cargo::error #14743

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Allow build scripts to report error messages through cargo::error #14743

merged 8 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. docs(ref): Clarify when warnings are shown

    @epage @ehuss
    epage authored and ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    198c1d8 View commit details
    Browse the repository at this point in the history

  2. test: Update to snapshot style.

    @torhovland @ehuss
    torhovland authored and ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3e59d08 View commit details
    Browse the repository at this point in the history

  3. test: cargo::error build script directive.

    @torhovland @ehuss
    torhovland authored and ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3fade07 View commit details
    Browse the repository at this point in the history

  4. feat: cargo::error build script directive.

    @torhovland @ehuss
    torhovland authored and ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    032bc29 View commit details
    Browse the repository at this point in the history

  5. Add MSRV note. 

    Co-authored-by: Weihang Lo <[email protected]>
    @torhovland @weihanglo @ehuss
    2 people authored and ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a94bce6 View commit details
    Browse the repository at this point in the history

  6. Update tests to resolve recent changes 

    Upstream changed these messages slightly.
    @ehuss
    ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9ce30a6 View commit details
    Browse the repository at this point in the history

  7. Add a note to library authors regarding cargo::error 

    There was a concern raised about potential use of `cargo::error` by
libraries, which could make it difficult for build script authors to
decide what is an error.
rust-lang#10159 (comment)
    @ehuss
    ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    deb028f View commit details
    Browse the repository at this point in the history

  8. Update MSRV for cargo::error

    @ehuss
    ehuss committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8639d7b View commit details
    Browse the repository at this point in the history