Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude semver check for cargo against referenced commit #13826

Closed
wants to merge 1 commit into from

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Apr 29, 2024

What does this PR try to resolve?

We always bump major versions for cargo package,
so the risk of shipping breaking change should be zero.

We still verify against crates.io as a sanity check.

How should we test and review this PR?

Check if CI is all green.

Additional information

See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/What.20is.20the.20reason.20for.20this.20error.3F/near/436053158

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
We always bump major versions for `cargo` package,
so the risk of shipping breaking change should be zero.

We still verify against crates.io as a sanity check.
@weihanglo
Copy link
Member Author

Close in favor of #13827.

@weihanglo weihanglo closed this Apr 29, 2024
@weihanglo weihanglo deleted the exclude-cargo branch April 29, 2024 14:22
@weihanglo weihanglo restored the exclude-cargo branch April 29, 2024 14:22
@weihanglo weihanglo deleted the exclude-cargo branch April 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants