-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc]:fix project to package #13820
[doc]:fix project to package #13820
Conversation
I'm going to check to see if the link jump is affected and set it to draft for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot how things actually work, but we need to ensure that every old link won't be dead and will redirect to the new one. Should check both page and fragment redirections.
I'm just talking about my own knowledge that there is a check for document linking in CI, but I don't know if it includes a check for fragment redirection. https://raw.githubusercontent.com/rust-lang/rust/master/src/tools/linkchecker/linkcheck.sh |
We need to make sure the redirection work. For example, https://doc.rust-lang.org/nightly/cargo/guide/project-layout.html must redirect to https://doc.rust-lang.org/nightly/cargo/guide/package-layout.html. |
Speaking of that. This only affects URLs. It is not really a thing user preceive, so might not be worth having this churn. |
@rustbot author |
Of course, this is not relevant to the big picture. I was just browsing the article and noticed this. The content of the URL doesn't match the content of the document, I just think it should be kept consistent. If this is difficult or otherwise, then feel free to turn it off. Thank you. @weihanglo |
mdbook supports cargo/src/doc/src/reference/manifest.md Lines 654 to 694 in 05364cb
I feel like there are more works with less consistency gain, so lean toward closing. What do you think? |
Ok, no problem there. In the future, it would be nice to be able to check the validity of the link jump in the CI. |
What does this PR try to resolve?
As
[project]
is being phased out, the filename should be consistent with the title of the file content.