Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolver): Treat unset MSRV as compatible #13791

Merged
merged 1 commit into from
May 1, 2024

Commits on Apr 23, 2024

  1. fix(resolver): Treat unset MSRV as compatible

    We last tweaked this logic in rust-lang#13066.
    However, we noticed this was inconsistent with `cargo add` in
    automatically selecting version requirements.
    
    It looks like this is a revert of rust-lang#13066, taking us back to the behavior
    in rust-lang#12950.
    In rust-lang#12950 there was a concern about the proliferation of no-MSRV and
    whether we should de-prioritize those to make the chance of success more
    likely.
    
    There are no right answes here, only which wrong answer is ok enough.
    - Do we treat lack of rust version as `rust-version = "*"` as some
      people expect or do we try to be smart?
    - If a user adds or removes `rust-version`, how should that affect the
      priority?
    
    One piece of new information is that the RFC for this has us trying to
    fill the no-MSRV gap with
    `rust-version = some-value-representing-the-current-toolchain>`.
    epage committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    89ead6f View commit details
    Browse the repository at this point in the history