refactor: Remove rust_2024_compatibility lint group
#13740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 11, 2024
refactor: Remove `rust_2024_compatibility` lint group The `rust_2024_compatibility` lint group was added as a way to be compatible with `Rust`. This group is meant to be used when switching to the 2024 edition (usually enabled by `cargo fix --edition`). Since we are not going to be interacting with `cargo fix` in the standard way to fix edition lints, this group is not needed at this time. Removing this will (slightly) reduce the complexity of working on things for the 2024 edition.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Not sure how bors failed, as the CI run for the PR did not fail on the same test. Must've been an odd CI bug. |
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
epage
added a commit
to epage/cargo
that referenced
this pull request
Apr 12, 2024
Seeing recent fialures on Windows - rust-lang#13748 - rust-lang#13738 - rust-lang#13740 and maybe more The test was added in rust-lang#12744. It seems of limited utility because there are innumerable ways of adding new writes that aren't atomic and we can't test for them all. Even this case, its limited. See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Flaky.20test.3A.20.20-death.3A.3Akill_cargo_add_never_corrupts_cargo/near/432979594
bors
added a commit
that referenced
this pull request
Apr 12, 2024
test: Remove add/remove death tests Seeing recent fialures on Windows - #13748 - #13738 - #13740 and maybe more The test was added in #12744. It seems of limited utility because there are innumerable ways of adding new writes that aren't atomic and we can't test for them all. Even this case, its limited. See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Flaky.20test.3A.20.20-death.3A.3Akill_cargo_add_never_corrupts_cargo/near/432979594
epage
added a commit
to epage/cargo
that referenced
this pull request
Apr 12, 2024
Seeing recent fialures on Windows - rust-lang#13748 - rust-lang#13738 - rust-lang#13740 and maybe more The test was added in rust-lang#12744. It seems of limited utility because there are innumerable ways of adding new writes that aren't atomic and we can't test for them all. Even this case, its limited. See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Flaky.20test.3A.20.20-death.3A.3Akill_cargo_add_never_corrupts_cargo/near/432979594
bors
added a commit
that referenced
this pull request
Apr 12, 2024
test: Remove add/remove death tests Seeing recent fialures on Windows - #13748 - #13738 - #13740 and maybe more The test was added in #12744. It seems of limited utility because there are innumerable ways of adding new writes that aren't atomic and we can't test for them all. Even this case, its limited. See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Flaky.20test.3A.20.20-death.3A.3Akill_cargo_add_never_corrupts_cargo/near/432979594
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
Update cargo 8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08 2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000 - test: Remove add/remove death tests (rust-lang/cargo#13750) - feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743) - feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742) - `cargo package -p no-exist` emitt error when the -p `package` not found (rust-lang/cargo#13735) - fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741) - test: don't compress test registry crates (rust-lang/cargo#13744) - feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738) - refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2024
Update cargo 8 commits in 74fd5bc730b828dbc956335b229ac34ba47f7ef7..48eca1b164695022295ce466b64b44e4e0228b08 2024-04-10 18:40:49 +0000 to 2024-04-12 21:16:36 +0000 - test: Remove add/remove death tests (rust-lang/cargo#13750) - feat(resolve): Fallback to 'rustc -V' for MSRV resolving (rust-lang/cargo#13743) - feat(cli): Add --ignore-rust-version to update/generate-lockfile (rust-lang/cargo#13742) - `cargo package -p no-exist` emitt error when the -p `package` not found (rust-lang/cargo#13735) - fix(help): Generalize --ignore-rust-version (rust-lang/cargo#13741) - test: don't compress test registry crates (rust-lang/cargo#13744) - feat(reslve): Respect '--ignore-rust-version' (rust-lang/cargo#13738) - refactor: Remove `rust_2024_compatibility` lint group (rust-lang/cargo#13740) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rust_2024_compatibilitylint group was added as a way to be compatible withRust. This group is meant to be used when switching to the 2024 edition (usually enabled bycargo fix --edition). Since we are not going to be interacting withcargo fixin the standard way to fix edition lints, this group is not needed at this time. Removing this will (slightly) reduce the complexity of working on things for the 2024 edition.