Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused sysroot_host_libdir #13468

Merged
merged 1 commit into from
Feb 21, 2024

Commits on Feb 20, 2024

  1. fix: remove unused sysroot_host_libdir

    Copy from <rust-lang#10469 (comment)>:
    
    > I've never been entirely clear why it does this. rust-lang#4006 didn't really
    > explain why it added the corresponding host_dylib_path. I can't envision
    > a scenario where it matters. I think compiler plugins and proc-macros
    > should load just fine, since libstd.so should already be loaded by the
    > compiler. Also, rustc uses rpath these days, and on Windows libstd.so is
    > placed in the bin directory which will be searched first anyways.
    >
    > On balance, I think it should be safe to just remove sysroot_host_libdir.
    > I can't come up with a scenario where it matters, at least on
    > windows/macos/linux. One issue is that this is most likely to affect
    > plugins, but those are deprecated and I think only Servo was the real
    > holdout. A concern is that nobody is going to test this use case before
    > it hits stable.
    
    Also,
    
    * compiler plugins were removed rust-lang/rust#116412
    * servo has moved off from plugins: servo/servo#30508
    
    So should generally be fine.
    weihanglo committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    4402b5c View commit details
    Browse the repository at this point in the history