Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Backport GitHub RSA key revocation #11892

Merged
merged 2 commits into from
Mar 26, 2023

Commits on Mar 26, 2023

  1. Auto merge of rust-lang#11883 - mitsuhiko:feature/new-github-rsa-host…

    …-key, r=arlosi
    
    Added new GitHub RSA Host Key
    
    GitHub rotated their RSA host key which means that cargo needs to update it.  Thankfully the other keys were not rotated so the impact depends on how cargo connected to github.
    
    Refs https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
    bors authored and ehuss committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    1db53cb View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#11889 - est31:revoke_old_github, r=ehuss

    Add the old github keys as revoked
    
    The patch to update the bundled ssh github host key did not change anything for users who already had connected to github one time before via ssh: if the attacker had access to the old key, they'd be vulnerable to MITM attacks as their known_hosts file would list the old github key. Only if they connected again to github without attacker access, or if they saw the announcement of the key rotation, they would update their key.
    
    There is sadly no other way to distribute revocations of old host keys to clients other than to bundle them with client software.
    
    cc rust-lang#11883
    bors authored and ehuss committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    d2a187b View commit details
    Browse the repository at this point in the history