Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper type for data that should never be logged #11545

Merged
merged 10 commits into from
Jan 20, 2023
Merged

Wrapper type for data that should never be logged #11545

merged 10 commits into from
Jan 20, 2023

Commits on Jan 5, 2023

  1. add Secret<T> wrapper type

    @kylematsuda
    kylematsuda committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    87feeb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. change Secret::into_inner to Secret::expose and make public; add a fe… 

    …w more needed utility methods
    @kylematsuda
    kylematsuda committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    9e732c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. add Secret<T> to RegistryCredentialConfig

    @kylematsuda
    kylematsuda committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e69a18e View commit details
    Browse the repository at this point in the history

  2. add Secret<T> to CredentialCacheValue

    @kylematsuda
    kylematsuda committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    b0bf846 View commit details
    Browse the repository at this point in the history

  3. add Secret<T> in private fn signatures in ops::registry and util::auth

    @kylematsuda
    kylematsuda committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    79b0216 View commit details
    Browse the repository at this point in the history

  4. add Secret<T> to pub fns in ops::registry and corresponding commands

    @kylematsuda
    kylematsuda committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    994ffbc View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. clean up wrapping with Secret in commands

    @kylematsuda
    kylematsuda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e2832a8 View commit details
    Browse the repository at this point in the history

  2. remove redundant Secret::from

    @kylematsuda
    kylematsuda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    36cad92 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. improve docs for Secret<T>; add doctest to assert that inner val is h… 

    …idden
    @kylematsuda
    kylematsuda committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    a32cef9 View commit details
    Browse the repository at this point in the history

  2. refactor some uses of Secret to avoid generating a token first before… 

    … wrapping in Secret
    @kylematsuda
    kylematsuda committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    efb972a View commit details
    Browse the repository at this point in the history