Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BETA-1.66] Fix wait-for-publish with sparse registry #11360

Closed
wants to merge 1 commit into from

Conversation

arlosi
Copy link
Contributor

@arlosi arlosi commented Nov 10, 2022

Beta backport of #11356

r? @epage

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2022
@epage
Copy link
Contributor

epage commented Nov 10, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 10, 2022

📌 Commit f0105c2 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022
@bors
Copy link
Contributor

bors commented Nov 10, 2022

⌛ Testing commit f0105c2 with merge 6cf01b8...

bors added a commit that referenced this pull request Nov 10, 2022
[BETA-1.66] Fix wait-for-publish with sparse registry

Beta backport of #11356

r? `@epage`
@bors
Copy link
Contributor

bors commented Nov 10, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2022
@ehuss
Copy link
Contributor

ehuss commented Nov 10, 2022

I'm a bit confused, can you say more about why this is being backported to beta if sparse registry only works on nightly?

@arlosi
Copy link
Contributor Author

arlosi commented Nov 10, 2022

@epage asked to backport it, but since it's nightly only, let's just close it.

@arlosi arlosi closed this Nov 10, 2022
@epage
Copy link
Contributor

epage commented Nov 10, 2022

Yeah, my bad for late night posting :). Was thinking through sparse users being impacted but overlooked that it would only be RUSTC_BOOTSTRAP users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants